LGTM, thanks.
On Fri, Aug 23, 2013 at 10:35 PM, Jose A. Lopes <[email protected]>wrote: > From: "Jose A. Lopes" <[email protected]> > > QA was adding 'SF_TYPE' to a list containing all storage fields (i.e., > 'VALID_STORAGE_FIELDS'). However, 'SF_TYPE' is already part of > 'VALID_STORAGE_FIELDS', which means this element was occurring twice > in the list. > > Signed-off-by: Jose A. Lopes <[email protected]> > --- > qa/qa_node.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qa/qa_node.py b/qa/qa_node.py > index 16fdb15..128f75c 100644 > --- a/qa/qa_node.py > +++ b/qa/qa_node.py > @@ -130,7 +130,7 @@ def TestNodeStorage(): > # Test all storage fields > cmd = ["gnt-node", "list-storage", "--storage-type", storage_type, > "--output=%s" % ",".join(list(constants.VALID_STORAGE_FIELDS) + > - [constants.SF_NODE, > constants.SF_TYPE])] > + [constants.SF_NODE])] > AssertCommand(cmd) > > # Get list of valid storage devices > -- > 1.8.3 > > -- Thomas Thrainer | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
