On Mon, Aug 26, 2013 at 4:44 PM, Guido Trotter <[email protected]> wrote:

> On Mon, Aug 26, 2013 at 4:38 PM, Thomas Thrainer <[email protected]>
> wrote:
> >
> >
> >
> > On Thu, Aug 22, 2013 at 10:16 AM, Helga Velroyen <[email protected]>
> wrote:
> >>
> >> This removes the '--no-drbd-storage' option completely
> >> from the command line interface.
> >>
> >> Signed-off-by: Helga Velroyen <[email protected]>
> >> ---
> >>  doc/design-hugepages-support.rst | 2 +-
> >>  lib/cli.py                       | 5 -----
> >>  lib/client/gnt_cluster.py        | 4 ++--
> >>  qa/qa_cluster.py                 | 6 ++++++
> >>  4 files changed, 9 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/doc/design-hugepages-support.rst
> >> b/doc/design-hugepages-support.rst
> >> index ff12978..62c4bce 100644
> >> --- a/doc/design-hugepages-support.rst
> >> +++ b/doc/design-hugepages-support.rst
> >> @@ -30,7 +30,7 @@ Hypervisor Parameters:
> >>  Currently, It is possible to set or modify huge pages mount point at
> >>  cluster level via the hypervisor parameter ``mem_path`` as::
> >>
> >> -       $ gnt-cluster init --no-lvm-storage --no-drbd-storage \
> >> +       $ gnt-cluster init \
> >
> >
> > --no-lvm-storage disappears as well? Is this an error? Otherwise state in
> > the commit description please.
> >
>
> It's already deprecated in 2.9 and master, so definitely we shouldn't
> reference to it in docs.
> But yes, updating the commit message won't hurt. :)
>

Okay, I updated the commit message to:

    CLI: actually remove the --no-drbd-storage option

    This removes the '--no-drbd-storage' option completely
    from the command line interface. The hugepages design
    doc still had a left-over reference to --no-lvm-storage,
    which is removed in this patch as well.

Cheers,
Helga

Reply via email to