On Tue, Sep 24, 2013 at 6:19 PM, Klaus Aehlig <[email protected]> wrote:
> On Tue, Sep 24, 2013 at 03:26:10PM +0000, Michele Tartara wrote: > > Newer pylint versions complain that QaConfig is not a proper container > because > > it does not implement the __len__(), __delitem__() and __setitem__() > methods. > > This commit implements them. > > > > Signed-off-by: Michele Tartara <[email protected]> > > --- > > qa/qa_config.py | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > Is there any rule you're following to decide where to put the new methods? > It seems pretty random to me. > They are right after __getitem__, which is the only existing method, so that all the container-related methods are together. > > Anyway, > > LGTM > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores > Thanks, Michele -- Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
