On Wed, Sep 25, 2013 at 6:59 AM, Guido Trotter <[email protected]> wrote:
> On Tue, Sep 24, 2013 at 6:49 PM, Michele Tartara <[email protected]> > wrote: > > Fix all instances of pep8's error: "E128 continuation line > under-indented for > > visual indent". > > > > Signed-off-by: Michele Tartara <[email protected]> > > LGTM > > Thanks, > > Guido > > PS did we update the style guide on the wiki to specify that we now > conform to this rule? > Theoretically, we always did: it was like that in all the examples on the wiki and in almost all the code. But apparently, pep8 wasn't checking for it, so a few errors (the ones fixed by this patch) managed to sneak through the code reviews. Just in case, I updated the wiki to explicitly state this rule, instead of only suggesting it through the examples. Cheers, Michele -- Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
