Re: [PATCH master 4/6] Check validity of the access protocol parameter

[Santi Raffa]

On Mon, Sep 30, 2013 at 11:35 AM, Thomas Thrainer <thoma...@google.com> wrote:
> Why split the string? It would fit on one line.

Personally I think it's kind of a dirty trick that results in better
readability than the alternative:

      if access not in constants.DISK_VALID_ACCESS_MODES:
        result.append(
          "Invalid value of '%s:%s': '%s' (expected one of %s)" % (
            constants.DT_RBD, constants.LDP_ACCESS, access,
            utils.CommaJoin(constants.DISK_VALID_ACCESS_MODES)
          )
        )

...but that is probably just me. :)

-- 
Raffa Santi
Google Germany GmbH
Dienerstr. 12
80331 München


Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores