LGTM, thanks.
On Wed, Oct 2, 2013 at 2:19 PM, Santi Raffa <[email protected]> wrote: > On Wed, Oct 2, 2013 at 1:53 PM, Thomas Thrainer <[email protected]> > wrote: > > The string has to start with "host", not merely contain it. > > I also thought about this, but I can think of no legal value of the > other syntax that can contain that string. You can refer to the syntax > checking regular expression I'd written [0]. OTOH, I also think it is > probably a better idea to check for the string start. Plus there's the > logic bug you spotted. > > [0]: http://goo.gl/7rTBfU > > Interdiff: > > diff --git a/lib/hypervisor/hv_xen.py b/lib/hypervisor/hv_xen.py > index ee80024..ae74fbd 100644 > --- a/lib/hypervisor/hv_xen.py > +++ b/lib/hypervisor/hv_xen.py > @@ -316,7 +316,7 @@ def _QuoteCpuidField(data): > > """ > > - return data if "host" in data else "'%s'" % data > + return "'%s'" % data if data.startswith("host") else data > > > class XenHypervisor(hv_base.BaseHypervisor): > > -- > Raffa Santi > Google Germany GmbH > Dienerstr. 12 > 80331 München > > > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Christine Elizabeth Flores > -- Thomas Thrainer | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
