LGTM. Thanks, Jose
On Tue, Oct 15, 2013 at 07:34:14PM +0200, Hrvoje Ribicic wrote: > Yes. It is not very intuitive, and I do not like it at all. > > Just by scanning, there is almost no way one could figure out what sort of > backend is being used from this call, or that there is a significant > difference between calls using the Python and the Haskell backend. > > On Tue, Oct 15, 2013 at 10:21 AM, Jose A. Lopes <[email protected]>wrote: > > > On Mon, Oct 14, 2013 at 10:25:31AM +0200, Hrvoje Ribicic wrote: > > > This commmit finally switches the instance query handling on. > > > > > > Signed-off-by: Hrvoje Ribicic <[email protected]> > > > --- > > > lib/client/gnt_instance.py | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/lib/client/gnt_instance.py b/lib/client/gnt_instance.py > > > index b9d8a13..18f52d2 100644 > > > --- a/lib/client/gnt_instance.py > > > +++ b/lib/client/gnt_instance.py > > > @@ -223,10 +223,12 @@ def ListInstances(opts, args): > > > for item in > > value), > > > False)) > > > > > > + cl = GetClient(query=True) > > > + > > > > Just for my information, given that I am unfamiliar with this code, is > > this the way of hooking this to Haskell? > > > > Thanks, > > Jose > > > > > return GenericList(constants.QR_INSTANCE, selected_fields, args, > > opts.units, > > > opts.separator, not opts.no_headers, > > > format_override=fmtoverride, verbose=opts.verbose, > > > - force_filter=opts.force_filter) > > > + force_filter=opts.force_filter, cl=cl) > > > > > > > > > def ListInstanceFields(opts, args): > > > -- > > > 1.8.4 > > > > > > > -- > > Jose Antonio Lopes > > Ganeti Engineering > > Google Germany GmbH > > Dienerstr. 12, 80331, München > > > > Registergericht und -nummer: Hamburg, HRB 86891 > > Sitz der Gesellschaft: Hamburg > > Geschäftsführer: Graham Law, Christine Elizabeth Flores > > Steuernummer: 48/725/00206 > > Umsatzsteueridentifikationsnummer: DE813741370 > > > > > > Hrvoje Ribicic > Ganeti Engineering > Google Germany GmbH > Dienerstr. 12, 80331, München > > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Christine Elizabeth Flores > Steuernummer: 48/725/00206 > Umsatzsteueridentifikationsnummer: DE813741370 -- Jose Antonio Lopes Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
