Guido: Patch has been moved to the beginning! Jose:
Before my change, Xen used to return an int, and KVM a string. I believe that this was just a question of parsing the response, and the Python version was much less strict. Thanks, Hrvoje On Tue, Oct 15, 2013 at 10:24 AM, Jose A. Lopes <[email protected]>wrote: > On Mon, Oct 14, 2013 at 10:25:32AM +0200, Hrvoje Ribicic wrote: > > The KVM hypervisor Python class returned a "0" value for the times > > field, which gets serialized as a string. As Haskell is more picky > > about types, this caused the entire response to be declared as invalid > > and broke status reporting. Fixed by changing the value to a proper > > int. > > > > Signed-off-by: Hrvoje Ribicic <[email protected]> > > --- > > lib/hypervisor/hv_kvm.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/hypervisor/hv_kvm.py b/lib/hypervisor/hv_kvm.py > > index c8ec34f..1718732 100644 > > --- a/lib/hypervisor/hv_kvm.py > > +++ b/lib/hypervisor/hv_kvm.py > > @@ -1000,7 +1000,7 @@ class KVMHypervisor(hv_base.BaseHypervisor): > > > > _, memory, vcpus = self._InstancePidInfo(pid) > > istat = "---b-" > > - times = "0" > > + times = 0 > > Is 'GetInstanceInfo' not used anymore in Python ? > This won't break the Hypervisor interface in Python ? > > Thanks, > Jose > > > > > try: > > qmp = QmpConnection(self._InstanceQmpMonitor(instance_name)) > > -- > > 1.8.4 > > > > -- > Jose Antonio Lopes > Ganeti Engineering > Google Germany GmbH > Dienerstr. 12, 80331, München > > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Christine Elizabeth Flores > Steuernummer: 48/725/00206 > Umsatzsteueridentifikationsnummer: DE813741370 > Hrvoje Ribicic Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
