LGTM,

Thanks,
Riba

On Thu, Oct 17, 2013 at 11:48 AM, Helga Velroyen <[email protected]> wrote:

> This fixes a unit test in instance_storage_unittest.py,
> which was affected by the recent change in the RCP
> 'node_info'.
>
> Signed-off-by: Helga Velroyen <[email protected]>
> ---
>  test/py/cmdlib/instance_storage_unittest.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/test/py/cmdlib/instance_storage_unittest.py
> b/test/py/cmdlib/instance_storage_unittest.py
> index 7874b5d..5e1db45 100755
> --- a/test/py/cmdlib/instance_storage_unittest.py
> +++ b/test/py/cmdlib/instance_storage_unittest.py
> @@ -73,7 +73,8 @@ class TestCheckNodesFreeDiskOnVG(unittest.TestCase):
>    def testPerformNodeInfoCall(self):
>      expected_hv_arg = [(self.hvname, self.hvparams)]
>      expected_storage_arg = {self.node_uuid:
> -        [(constants.ST_LVM_VG, self.vg, [self.es])]}
> +        [(constants.ST_LVM_VG, self.vg, [self.es]),
> +         (constants.ST_LVM_PV, self.vg, [self.es])]}
>      instance_storage._PerformNodeInfoCall(self.lu, self.node_uuids,
> self.vg)
>      self.lu.rpc.call_node_info.assert_called_with(
>          self.node_uuids, expected_storage_arg, expected_hv_arg)
> --
> 1.8.4
>
>


Hrvoje Ribicic
Ganeti Engineering
Google Germany GmbH
Dienerstr. 12, 80331, München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores
Steuernummer: 48/725/00206
Umsatzsteueridentifikationsnummer: DE813741370

Reply via email to