LGTM, thanks
On Thu, Oct 31, 2013 at 2:58 PM, Klaus Aehlig <[email protected]> wrote: > The target resources, as used by hsqueeze, are supposed to > be strictly higher than the minimal resources. However, > keeping minimal resources of less than a single instance > is not a useful reserve. > > Signed-off-by: Klaus Aehlig <[email protected]> > --- > src/Ganeti/HTools/CLI.hs | 2 +- > test/hs/shelltests/htools-hsqueeze.test | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/Ganeti/HTools/CLI.hs b/src/Ganeti/HTools/CLI.hs > index d052593..18deb94 100644 > --- a/src/Ganeti/HTools/CLI.hs > +++ b/src/Ganeti/HTools/CLI.hs > @@ -225,7 +225,7 @@ defaultOptions = Options > , optShowNodes = Nothing > , optShowVer = False > , optStdSpec = Nothing > - , optTargetResources = 1.0 > + , optTargetResources = 2.0 > , optTestCount = Nothing > , optTieredSpec = Nothing > , optReplay = Nothing > diff --git a/test/hs/shelltests/htools-hsqueeze.test > b/test/hs/shelltests/htools-hsqueeze.test > index ec1d4b0..14fb631 100644 > --- a/test/hs/shelltests/htools-hsqueeze.test > +++ b/test/hs/shelltests/htools-hsqueeze.test > @@ -1,10 +1,10 @@ > -./test/hs/hsqueeze --no-headers -t > $TESTDATA_DIR/hsqueeze-underutilized.data > +./test/hs/hsqueeze --no-headers --target-resources=1.0 -t > $TESTDATA_DIR/hsqueeze-underutilized.data > >>>/^node-01-00[2345] > node-01-00[2345] > node-01-00[2345]$/ > >>>= 0 > > -./test/hs/hsqueeze --no-headers --target-resources=2.0 -t > $TESTDATA_DIR/hsqueeze-underutilized.data > +./test/hs/hsqueeze --no-headers -t > $TESTDATA_DIR/hsqueeze-underutilized.data > >>>/^node-01-00[2345] > node-01-00[2345]$/ > >>>= 0 > -- > 1.8.4.1 > > -- -- Helga Velroyen | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
