LGTM, thanks.
On Thu, Nov 7, 2013 at 3:52 PM, Klaus Aehlig <[email protected]> wrote: > When comparing for consistency of the DRBD versions, some > versions might not be available via RPC, typically, if the > node is offline. In this case, leave these nodes out of the > test, instead of failing with an internal python error. > > Signed-off-by: Klaus Aehlig <[email protected]> > --- > lib/cmdlib/cluster.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lib/cmdlib/cluster.py b/lib/cmdlib/cluster.py > index b855f5a..4183825 100644 > --- a/lib/cmdlib/cluster.py > +++ b/lib/cmdlib/cluster.py > @@ -1828,8 +1828,9 @@ class LUClusterVerifyGroup(LogicalUnit, > _VerifyErrors): > node_versions = {} > for node_uuid, ndata in node_verify_infos.items(): > nresult = ndata.payload > - version = nresult.get(constants.NV_DRBDVERSION, "Missing DRBD > version") > - node_versions[node_uuid] = version > + if nresult: > + version = nresult.get(constants.NV_DRBDVERSION, "Missing DRBD > version") > + node_versions[node_uuid] = version > > if len(set(node_versions.values())) > 1: > for node_uuid, version in sorted(node_versions.items()): > -- > 1.8.4.1 > > -- Thomas Thrainer | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
