On Thu, Nov 7, 2013 at 4:04 PM, Klaus Aehlig <[email protected]> wrote:
> As the base parameters also includes the reason trail,
> set it, if not set already, together with the other
> base parameters in the case of an opcode expanding to
> a list of opcodes.
>
> Signed-off-by: Klaus Aehlig <[email protected]>
> ---
>  lib/mcpu.py | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/lib/mcpu.py b/lib/mcpu.py
> index 5a04805..57956ca 100644
> --- a/lib/mcpu.py
> +++ b/lib/mcpu.py
> @@ -211,6 +211,10 @@ def _SetBaseOpParams(src, defcomment, dst):
>    if not getattr(dst, opcodes_base.COMMENT_ATTR, None):
>      dst.comment = defcomment
>
> +  # FIXME: extend reason trail, showing the derivedness
> +  if not getattr(dst, constants.OPCODE_REASON, None):
> +    dst.reason = getattr(src, constants.OPCODE_REASON, [])
> +
>
>  def _ProcessResult(submit_fn, op, result):
>    """Examines opcode result.
> --
> 1.8.4.1
>

LGTM, thanks.

Michele

-- 
Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to