On Thu, Nov 7, 2013 at 1:20 PM, Klaus Aehlig <[email protected]> wrote: > > This patch continues the work described in "Ganeti daemons > refactoring". The first step, renaming queryd to luxid has already > happened in 2.8. In this patch series, the first part of the second > step is achieved: the responsibility for the queue, in particular the > allocation of job ids, is taken over by luxid; masterd still decides > when to execute which job. > > > > Klaus Aehlig (22): > Provide utility to atomically write a file > Add utility function tryAndLogIOError > Provide a convenience method to optain a QueuedOpCode > Add function to compute the absolute id of a dependency > Add function to resolve dependencies in meta op code > Provide convenience function to create Job from op-codes > Provide method read job serial number > Provide function to obtain the single element of a list > Support RPC asking to replicate part of the job queue > Add function to get master candidates from configuration > Provide means to allocate new job ids > Provide a function to write jobs to disk > Provide path to the queue lock file > Provide means of locking a file > Factor out functionality to pickup a job from the queue > Add Luxi Request to pick up a job in the queue > Provide path to the queue drain file > Add the predicate of the queue being open > Make luxid handle SubmitJob > Make luxid handle SubmitManyJobs > Set reason trail for derived opcodes > Make masterd call luxid to write jobs to queue > > lib/jqueue.py | 229 > +++++++----------------------- > lib/luxi.py | 5 + > lib/mcpu.py | 4 + > lib/server/masterd.py | 5 + > src/Ganeti/Config.hs | 7 + > src/Ganeti/JQueue.hs | 95 +++++++++++++ > src/Ganeti/Luxi.hs | 6 + > src/Ganeti/OpCodes.hs | 14 ++ > src/Ganeti/Path.hs | 10 ++ > src/Ganeti/Query/Server.hs | 123 ++++++++++++---- > src/Ganeti/Rpc.hs | 32 ++++- > src/Ganeti/Types.hs | 12 ++ > src/Ganeti/Utils.hs | 43 +++++- > test/hs/Test/Ganeti/Luxi.hs | 1 + > test/py/ganeti.rapi.testutils_unittest.py | 1 + > 15 files changed, 378 insertions(+), 209 deletions(-) > > -- > 1.8.4.1 >
Great patch series, really well split in small patches that were easy to review independently! Thanks, Michele -- Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
