This change is responding to a valid problem - the newly raised exception could swallow up a previously raised one, causing loss of information in the traceback. However, in many cases no exception is present, and there this logging command will print a slightly confusing None.
This suggests that the problem could be solved better, so please propose a different fix! :) On Mon, Nov 11, 2013 at 6:47 PM, Santi Raffa <[email protected]> wrote: > On Mon, Nov 11, 2013 at 6:44 PM, Santi Raffa <[email protected]> wrote: > > Allow the appending arbitrary debug info. > > Sorry; this part of the commit message is erroneous. The correct > commit description is: > > "When logging an exception, also write the full traceback to log." > > -- > Raffa Santi > Google Germany GmbH > Dienerstr. 12 > 80331 München > > > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Christine Elizabeth Flores > Hrvoje Ribicic Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
