According to our development guidelines, the patch requires a 20+ char commit message body as it modifies over 4 lines of code.
Apart from that, LGTM, so just respond with a body :) On Mon, Nov 11, 2013 at 4:37 PM, Petr Pudlak <[email protected]> wrote: > Signed-off-by: Petr Pudlak <[email protected]> > --- > src/Ganeti/HsConstants.hs | 7 ++++++- > src/Ganeti/Objects.hs | 1 + > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/Ganeti/HsConstants.hs b/src/Ganeti/HsConstants.hs > index f5c2c1f..803ebdb 100644 > --- a/src/Ganeti/HsConstants.hs > +++ b/src/Ganeti/HsConstants.hs > @@ -1990,6 +1990,9 @@ ndOvsLink = "ovs_link" > ndOvsName :: String > ndOvsName = "ovs_name" > > +ndSshPort :: String > +ndSshPort = "ssh_port" > + > ndsParameterTypes :: Map String VType > ndsParameterTypes = > Map.fromList > @@ -1998,7 +2001,8 @@ ndsParameterTypes = > (ndOvs, VTypeBool), > (ndOvsLink, VTypeMaybeString), > (ndOvsName, VTypeMaybeString), > - (ndSpindleCount, VTypeInt)] > + (ndSpindleCount, VTypeInt), > + (ndSshPort, VTypeInt)] > > ndsParameters :: FrozenSet String > ndsParameters = ConstantUtils.mkSet (Map.keys ndsParameterTypes) > @@ -3692,6 +3696,7 @@ ndcDefaults = > , (ndOvs, PyValueEx False) > , (ndOvsName, PyValueEx defaultOvs) > , (ndOvsLink, PyValueEx "") > + , (ndSshPort, PyValueEx (22 :: Int)) > ] > > ndcGlobals :: FrozenSet String > diff --git a/src/Ganeti/Objects.hs b/src/Ganeti/Objects.hs > index 40e8a50..575dd72 100644 > --- a/src/Ganeti/Objects.hs > +++ b/src/Ganeti/Objects.hs > @@ -545,6 +545,7 @@ $(buildParam "ND" "ndp" > , simpleField "ovs" [t| Bool |] > , simpleField "ovs_name" [t| String |] > , simpleField "ovs_link" [t| String |] > + , simpleField "ssh_port" [t| Int |] > ]) > > $(buildObject "Node" "node" $ > -- > 1.8.4.1 > > Hrvoje Ribicic Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
