LGTM, thanks On Thu, Nov 14, 2013 at 11:06 PM, Klaus Aehlig <[email protected]> wrote:
> When grouping moves into jobs, a new job set is started, if the new > move involves a node also touched by a previous move. When computing > the list of involved nodes, the new primary and secondary nodes of the > instance are included; if an instance, however, has only one node, the > "no secondary" index -1 should be left out to avoid spurious conflicts > between unrelated moves of single-homed instances. > > Signed-off-by: Klaus Aehlig <[email protected]> > --- > src/Ganeti/HTools/Cluster.hs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/Ganeti/HTools/Cluster.hs b/src/Ganeti/HTools/Cluster.hs > index fe3432c..6eb0ef1 100644 > --- a/src/Ganeti/HTools/Cluster.hs > +++ b/src/Ganeti/HTools/Cluster.hs > @@ -1410,7 +1410,7 @@ involvedNodes :: Instance.List -- ^ Instance list, > used for retrieving > involvedNodes il plc = > let (i, np, ns, _, _) = plc > inst = Container.find i il > - in nub $ [np, ns] ++ Instance.allNodes inst > + in nub . filter (>= 0) $ [np, ns] ++ Instance.allNodes inst > > -- | Inner function for splitJobs, that either appends the next job to > -- the current jobset, or starts a new jobset. > -- > 1.8.4.1 > > Hrvoje Ribicic Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
