Sorry for not catching that one, the change LGTM On Fri, Nov 15, 2013 at 3:45 PM, Klaus Aehlig <[email protected]> wrote:
> On Fri, Nov 15, 2013 at 02:20:18PM +0100, Hrvoje Ribicic wrote: > > Thank you, much better. LGTM! > > Except that the interdiff had a typo. So I'd like to fix it > with the following, additional, interdiff. > > second interdiff patch 3 > > diff --git a/src/Ganeti/HTools/Cluster.hs b/src/Ganeti/HTools/Cluster.hs > index 6cb7229..054a8dc 100644 > --- a/src/Ganeti/HTools/Cluster.hs > +++ b/src/Ganeti/HTools/Cluster.hs > @@ -1421,7 +1421,7 @@ getMoves (Table _ initial_il _ initial_plc, Table > final_nl _ _ final_plc) = > plctoMoves (plc@(idx, p, s, mv, _)) = > let inst = Container.find idx initial_il > inst_name = Instance.name inst > - affected = involvedNodes initial_il initial_plc > + affected = involvedNodes initial_il plc > np = Node.alias $ Container.find p final_nl > ns = Node.alias $ Container.find s final_nl > (_, cmds) = computeMoves inst inst_name mv np ns > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores > Hrvoje Ribicic Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
