Updates:
        Status: Fixed

Comment #8 on issue 235 by [email protected]: Allow for non-standard ssh ports
http://code.google.com/p/ganeti/issues/detail?id=235

Fixed in patch series:

commit 3ff2cf5542715094ac62969abd793f85880e8cd4
Author: Petr Pudlak <[email protected]>
Date:   Fri Nov 8 17:21:38 2013 +0100

    Design document for custom SSH ports

See issue 235. It turned out the feature is a bit more complex than expected,
    hence this design doc.

    Signed-off-by: Petr Pudlak <[email protected]>
    Signed-off-by: Klaus Aehlig <[email protected]>
    Reviewed-by: Klaus Aehlig <[email protected]>

commit f2152285738a2d88c2b9e816045a0edfd268d7f4
Author: Petr Pudlak <[email protected]>
Date:   Thu Nov 14 15:31:23 2013 +0000

    Add "ndp/ssh_port" node group configuration parameter

    The parameter is added to Haskell sources, from which the corresponding
    Python code is generated.

    Signed-off-by: Petr Pudlak <[email protected]>
    Reviewed-by: Hrvoje Ribicic <[email protected]>

commit a9f33339b9ddf8787144e8a28a9d70922b5723f5
Author: Petr Pudlak <[email protected]>
Date:   Tue Nov 12 15:28:40 2013 +0100

    Use custom SSH ports in node groups when working with nodes

    Calling `gnt-instance console` with a custom SSH port doesn't work yet.

    Signed-off-by: Petr Pudlak <[email protected]>
    Reviewed-by: Hrvoje Ribicic <[email protected]>

commit 33ffda6c8752a772246ae730585794232dd42e46
Author: Petr Pudlak <[email protected]>
Date:   Mon Nov 11 16:37:26 2013 +0100

    Update unit tests for custom SSH ports

    The unit tests now include the configurations of SSH ports for node
    groups/nodes.

    Signed-off-by: Petr Pudlak <[email protected]>
    Reviewed-by: Hrvoje Ribicic <[email protected]>

commit c42be2c044383376c2ca608f307e0d5d29e6f872
Author: Petr Pudlak <[email protected]>
Date:   Mon Nov 11 16:37:27 2013 +0100

    Use configured SSH ports when connecting to a console

    This is accomplished by passing the corresponding node group to
    hv_*.py. Tests for hv_*.py that call GetInstanceConsole updated.

    Signed-off-by: Petr Pudlak <[email protected]>
    Reviewed-by: Hrvoje Ribicic <[email protected]>

commit 651ce6a3d3083236580a71de0ca7096fd0715315
Author: Petr Pudlak <[email protected]>
Date:   Mon Nov 11 16:37:28 2013 +0100

    Use custom SSH ports for other operations

    In particular _copyfile_ and _renew-crypto_.

    Signed-off-by: Petr Pudlak <[email protected]>
    Reviewed-by: Hrvoje Ribicic <[email protected]>

commit ec7b6d639abbdc08a3b3dd852b363972f2d3fa8c
Author: Petr Pudlak <[email protected]>
Date:   Mon Nov 11 16:37:29 2013 +0100

    Update QA to test custom SSH ports

    This patch adds the `ssh-port` option. If set to a non-standard port,
    the QA script sets up the default node group with this port, and before
    running tests it adds `iptable` rules to all nodes so that the nodes
    see each other's SSH servers as running on this port.
    Their SSH configuration is _not_ changed and other machines see the
    nodes on 22 as before.

    The `iptable` rules are reset on each QA run, trying to preserve any
    existing rules (not created by the script) that might be present.

    Signed-off-by: Petr Pudlak <[email protected]>
    Reviewed-by: Hrvoje Ribicic <[email protected]>

commit 836ce0c853b92275fbcace3cef607fc1584b04fc
Author: Petr Pudlak <[email protected]>
Date:   Tue Nov 12 15:44:49 2013 +0100

    Include *ssh_port* in the man page

    Added to the other node parameters in ganeti.rst.

    Signed-off-by: Petr Pudlak <[email protected]>
    Reviewed-by: Hrvoje Ribicic <[email protected]>

commit 8cd19becf5b8b666d9bfcf0007f32d4b05fe8c32
Author: Petr Pudlak <[email protected]>
Date:   Mon Nov 11 16:37:31 2013 +0100

    Update custom SSH ports config when downgrading to 2.10

    If SSH ports other than 22 are configured, abort the config downgrade,
    as the operation would certainly fail. Otherwise just remove
    _ndparams/ssh_port_ from the configuration.

    Signed-off-by: Petr Pudlak <[email protected]>
    Reviewed-by: Hrvoje Ribicic <[email protected]>

commit 70e6a07e4d5d947f24d64f972e9af09f5c3e1637
Author: Petr Pudlak <[email protected]>
Date:   Mon Nov 11 16:37:32 2013 +0100

    Update NEWS with information about custom SSH ports

    Signed-off-by: Petr Pudlak <[email protected]>
    Reviewed-by: Hrvoje Ribicic <[email protected]>

commit b337aeb4e587ffd8c93966746865c5f70afb3450
Author: Petr Pudlak <[email protected]>
Date:   Mon Nov 11 16:37:34 2013 +0100

    Export `NodeAdd` and `NodeRemove` from qa_node

    This is needed for testing SSH ports so that we can remove a node from
    a group, add it to a group with a custom SSH port, and then undo the
    change.

    Signed-off-by: Petr Pudlak <[email protected]>
    Reviewed-by: Hrvoje Ribicic <[email protected]>

commit 02911a56c64935be344c5da2e3742c175a040716
Author: Petr Pudlak <[email protected]>
Date:   Mon Nov 11 16:37:35 2013 +0100

    Add a simple QA test for a group with a custom SSH port

    The test is turned on by setting `"group-custom-ssh-port": true` in
    the config.

    Unlike `"ssh-port": ...` in "options", this is a single test that
    doesn't affect the rest of the tests.

    Signed-off-by: Petr Pudlak <[email protected]>
    Reviewed-by: Hrvoje Ribicic <[email protected]>

commit 0808e9d58f50dab77b33a9cdac804e978b9a0eee
Author: Petr Pudlak <[email protected]>
Date:   Thu Nov 14 10:31:34 2013 +0100

    Add NodeGroup to InstanceConsoleInfoParams

    Before, calls to `gnt-instance list -o console` with an instance on a
    node with a custom SSH port failed because of missing group
    configuration. This patch fixes the problem.

    Signed-off-by: Petr Pudlak <[email protected]>
    Reviewed-by: Hrvoje Ribicic <[email protected]>

commit a02dbfca0cae1b7028c888f045940d20d772ee83
Author: Petr Pudlak <[email protected]>
Date:   Wed Nov 20 08:40:15 2013 +0100

    Add an IPv6 check for the QA test of custom SSH ports

    If any of the nodes involved would be reached through IPv6, the test is
    skipped. This is because the required testing setup using "iptables" is
    suiteble only for IPv4 and doesn't work for IPv6 connections.

    Signed-off-by: Petr Pudlak <[email protected]>
    Reviewed-by: Helga Velroyen <[email protected]>


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

Reply via email to