LGTM, no need to resend interdiff if the name of the parsing function changes depending on your response to the second patch.
Thanks! On Mon, Dec 2, 2013 at 8:47 PM, Klaus Aehlig <[email protected]> wrote: > The backed parameters specifying the minimal/maximal memory > can also be passed as values with suffixes. Support parsing > these values. > > Signed-off-by: Klaus Aehlig <[email protected]> > --- > src/Ganeti/Objects.hs | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/Ganeti/Objects.hs b/src/Ganeti/Objects.hs > index 8036918..fa1a9da 100644 > --- a/src/Ganeti/Objects.hs > +++ b/src/Ganeti/Objects.hs > @@ -103,7 +103,7 @@ import qualified Ganeti.ConstantUtils as ConstantUtils > import Ganeti.JSON > import Ganeti.Types > import Ganeti.THH > -import Ganeti.Utils (sepSplit, tryRead) > +import Ganeti.Utils (sepSplit, tryRead, parseUnitLarge) > > -- * Generic definitions > > @@ -421,8 +421,10 @@ includesLogicalId vg_name lv_name disk = > -- * Instance definitions > > $(buildParam "Be" "bep" > - [ simpleField "minmem" [t| Int |] > - , simpleField "maxmem" [t| Int |] > + [ specialNumericalField 'parseUnitLarge > + $ simpleField "minmem" [t| Int |] > + , specialNumericalField 'parseUnitLarge > + $ simpleField "maxmem" [t| Int |] > , simpleField "vcpus" [t| Int |] > , simpleField "auto_balance" [t| Bool |] > , simpleField "always_failover" [t| Bool |] > -- > 1.8.4.1 > >
