OK, no problem, thanks.
On Thu, Dec 5, 2013 at 3:41 PM, Klaus Aehlig <[email protected]> wrote: > On Thu, Dec 05, 2013 at 10:17:58AM +0100, Petr Pudlak wrote: > > Instead of passing a bare server socket around, we pass it encapsulated > > in a data type together with parameters such as read/write timeouts. > > > > Rename `getClient/Server` to `getLuxiClient/Server`. > > > > Signed-off-by: Petr Pudlak <[email protected]> > > --- > > src/Ganeti/HTools/Backend/Luxi.hs | 2 +- > > src/Ganeti/HTools/Program/Harep.hs | 4 +- > > src/Ganeti/HTools/Program/Hbal.hs | 2 +- > > src/Ganeti/JQueue.hs | 2 +- > > src/Ganeti/Luxi.hs | 18 ++++++++- > > src/Ganeti/Query/Server.hs | 7 ++-- > > src/Ganeti/UDSServer.hs | 81 > ++++++++++++++++++++++++-------------- > > test/hs/Test/Ganeti/Luxi.hs | 4 +- > > 8 files changed, 78 insertions(+), 42 deletions(-) > > The net effect looks good, but I would separate the renaming into a > separate > patch to separate concerns and improve readability of the patches. > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
