LGTM, thanks
On Fri, Dec 20, 2013 at 10:09 AM, Hrvoje Ribicic <[email protected]> wrote: > A test relying on RAPI alone cannot exercise the RecreateInstanceDisks > functionality properly - simply because it cannot damage an instance > to the point where its disks would be missing and in need of > recreation. The test is left standing simply to test if the operation > is still exposed via the interface. > > Signed-off-by: Hrvoje Ribicic <[email protected]> > --- > qa/rapi-workload.py | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/qa/rapi-workload.py b/qa/rapi-workload.py > index 6d33802..7d9699d 100755 > --- a/qa/rapi-workload.py > +++ b/qa/rapi-workload.py > @@ -314,6 +314,9 @@ def TestSingleInstance(client, instance_name, > alternate_name, node_one, > > Finish(client, client.ActivateInstanceDisks, instance_name) > > + # Note that the RecreateInstanceDisks command will always fail, as > there is > + # no way to induce the necessary prerequisites (removal of LV) via RAPI. > + # Keeping it around allows us to at least know that it still exists. > Finish(client, client.RecreateInstanceDisks, > instance_name, [0], [node_one]) > > -- > 1.8.5.1 > > -- -- Helga Velroyen | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
