LGTM, thanks
On Tue, Jan 7, 2014 at 10:30 AM, Klaus Aehlig <[email protected]> wrote: > > > luxidJobqueuePollInterval :: Int > > > -luxidJobqueuePollInterval = 3 > > > +luxidJobqueuePollInterval = 307 > > > > > > > Thats an unusal magic number. Please add a comment why this is a good > > choice. > > Oh, sorry, I should have explained, why I choose the smallest prime larger > than 300. > > commit fb7f10e0053f9608c31043b92de8d2d74ea00ac0 > Author: Klaus Aehlig <[email protected]> > Date: Tue Jan 7 10:29:49 2014 +0100 > > Interdiff [PATCH master 6/6] Increase job queue polling interval > > diff --git a/src/Ganeti/Constants.hs b/src/Ganeti/Constants.hs > index 7ded77b..6afec5d 100644 > --- a/src/Ganeti/Constants.hs > +++ b/src/Ganeti/Constants.hs > @@ -3932,7 +3932,9 @@ partReserved = 0.02 > -- intervall is only relevant if the number of running jobs reaches the > maximal > -- allowed number, as otherwise new jobs will be started immediately > anyway. > -- Also, as jobs are watched via inotify, scheduling usually works > independent > --- of polling. > +-- of polling. Therefore we chose a sufficiently large interval, in the > order of > +-- 5 minutes. As with the interval for reloading the configuration, we > chose a > +-- prime number to avoid accidental 'same wakeup' with other processes. > luxidJobqueuePollInterval :: Int > luxidJobqueuePollInterval = 307 > > > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores > -- -- Helga Velroyen | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
