LGTM, thanks
On Tue, Jan 7, 2014 at 10:42 AM, Klaus Aehlig <[email protected]> wrote: > > Hm, I see your problem. I don't really have a better suggestion, but I > > would be fine in this case if you just add a comment saying what > component > > of JobWithStat jWS is/represents. > > As discussed offline, I'll add the following interdiff > > > commit 62b498b6dd3e69781e66bf704cecb024ba82f76b > Author: Klaus Aehlig <[email protected]> > Date: Tue Jan 7 10:38:28 2014 +0100 > > Interdiff [PATCH master 1/6] Add an optional inotify to jobs in the > scheduler > > diff --git a/src/Ganeti/JQScheduler.hs b/src/Ganeti/JQScheduler.hs > index ad94b3c..e35f703 100644 > --- a/src/Ganeti/JQScheduler.hs > +++ b/src/Ganeti/JQScheduler.hs > @@ -123,6 +123,7 @@ readJobStatus jWS@(JobWithStat {jStat=fstat, > jJob=job}) = do > logDebug > $ "Read job " ++ jids ++ ", staus is " ++ show (calcJobStatus > job') > return . Just $ jWS {jStat=fstat', jJob=job'} > + -- jINotify unchanged > > -- | Update a job in the job queue, if it is still there. This is the > -- pure function for inserting a previously read change into the queue. > > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores > -- -- Helga Velroyen | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
