Hi Klaus,
On Thu, Jan 9, 2014 at 10:10 AM, Klaus Aehlig <[email protected]> wrote: > > Hi Petr, > > > Also I'd be in favor of submitting a patch series that would fix known > > violations in the existing code against the style guide. > > > > For example, I could set my editor to automatically remove trailing > > white-spaces, but without fixing existing trailing white-spaces in the > > code, this would just mess things up. > > I'm not a big fan of these only-style changes, especially if it's only > white space. They mess up authorship and make merges unnecessary hard. > You're right, I didn't think of merging and authorship (like git blame). > > However, for parts of the code only on master, it would make sense, to > clean them up before forking off 2.11. For the rest, I'd prefere the > traditional slow approach: if a patch series touches a function anyway, > it should also contain a patch cleaning up the style violations there. > > What do you think? > Sounds good. So before forking we'd do a diff of what has changed since 2.10 and corrected violations we see there?
