LGTM, thanks!
On Mon, Jan 13, 2014 at 11:04 AM, Klaus Aehlig <[email protected]> wrote: > > Either way, a simpler way of writing this is: > > > > return version < (major, minor, revision) > > or > > return version_one < version_two > > > You're absolutely right. > > Interdiff patch 1: Add utility to compare versions > > diff --git a/lib/utils/version.py b/lib/utils/version.py > index 1046d8e..442fa46 100644 > --- a/lib/utils/version.py > +++ b/lib/utils/version.py > @@ -171,13 +171,4 @@ def IsBefore(version, major, minor, revision): > if version is None: > return True > > - if version[0] < major: > - return True > - > - if version[0] == major and version[1] < minor: > - return True > - > - if version[0] == major and version[1] == minor and version[2] < > revision: > - return True > - > - return False > + return version < (major, minor, revision) > > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
