Ah, I understand. Thanks for the explanation. Petr
On Wed, Jan 15, 2014 at 1:25 PM, Klaus Aehlig <[email protected]> wrote: > On Wed, Jan 15, 2014 at 01:17:33PM +0100, Petr Pudlák wrote: > > LGTM, thanks > > > > (Jose just mentioned that he has seen GHC making a difference between '_ > <- > > x' and just 'x'. I thought there is no difference, at least in the > > mathematical sense, but perhaps there is some.) > > There is a style difference: if 'x' has type different from 'IO ()', then > just writing 'x' would implicitly (i.e., without explicitly showing the > discard > in the code) discard a non-() value, which is bad style and the compiler > warns > about (and warnings are fatal in Ganeti). > > In this particular case, however, 'replicateManyJobs' is always only best > effort, > as the change already happened in the job (and as soon as it is written on > master > there is no chance to pretend no one has seen it); so, as the result > cannont be > handled in any situation, 'replicateManyJobs' already has > type 'FilePath -> [Node] -> [QueuedJob] -> IO ()'. > > Best, > Klaus > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
