Yes, that is a typo. I'll fix it - s/Applicative/Alternative/
On Thu, Jan 16, 2014 at 3:06 PM, Klaus Aehlig <[email protected]> wrote: > > In the title of the patch: shouldn't it read "Alternative" > instead of "Applicative"? At least, that's the instance > you're actually adding. > > > This allows to use Applicative specific combinators, namely `optional`. > > Maybe here as well? While `optional` is from Control.Applicative, its > type is > > optional :: Alternative f => f a -> f (Maybe a) > > so it is actually Alternative-specific. > > > Signed-off-by: Petr Pudlak <[email protected]> > > --- > > src/Ganeti/BasicTypes.hs | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > [...] > > Rest LGTM. > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
