On Thu, Jan 16, 2014 at 2:32 PM, Michele Tartara <[email protected]> wrote: > On Fri, Jan 10, 2014 at 9:29 PM, Dimitris Aragiorgis <[email protected]> wrote: >> * Dimitris Aragiorgis <[email protected]> [2014-01-10 15:00:08 +0200]: >> >>> In case of DRBD, hooks run on both primary (source) and secondary >>> (target) nodes. To get the same behavior for DTS_EXT_MIRROR, where we >>> do not have secondary node, we should explicitly add target node to >>> hooks nodes during instance migration/failover. >>> >>> CheckPrereq() of TLMigrateInstance runs before BuildHooksManager(), >>> thus target_node calculated by Iallocator is available under >>> self._migrater.target_node. Use this value instead of >>> self.op.target_node which can be None. >>> >>> Update NEWS and related doc entries. >>> >>> Signed-off-by: Dimitris Aragiorgis <[email protected]> >>> --- >>> NEWS | 2 ++ >>> doc/hooks.rst | 8 ++++---- >>> lib/cmdlib/instance_migration.py | 10 +++++++--- >>> 3 files changed, 13 insertions(+), 7 deletions(-) >>> >>> diff --git a/NEWS b/NEWS >>> index 26c2616..c383d48 100644 >>> --- a/NEWS >>> +++ b/NEWS >>> @@ -21,6 +21,8 @@ Incompatible/important changes >>> checks whether there are instances still using those templates. >>> - 'gnt-node list-storage' now also reports storage information about >>> file-based storage types. >>> +- In case of non drbd instances, export *_SECONDARY environment variables >> >> Here apparently I forgot to escape * ... >> If the rest looks OK could you please fix it before pushing it? >> >> Thanks, >> dimara >> > > Sure, I can do that. > > I'm having a look at the patch right now, and I'll let you know about it soon. > > Cheers, > Michele > -- > Google Germany GmbH > Dienerstr. 12 > 80331 München > > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Christine Elizabeth Flores
LGTM, thanks. Michele -- Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
