Good idea, I'll squash these two patches.
On Thu, Jan 16, 2014 at 3:50 PM, Klaus Aehlig <[email protected]> wrote: > On Thu, Jan 16, 2014 at 02:28:06PM +0100, Petr Pudlak wrote: > > Now that handling optional fields is corrected, this helper function is > > no longer necessary. > > > > Signed-off-by: Petr Pudlak <[email protected]> > > --- > > src/Ganeti/THH.hs | 7 ------- > > 1 file changed, 7 deletions(-) > > To be pedantic, this patch should be squashed into the previous one, > as otherwise, after the first patch we have a function defined but > not used, causing a compiler warning, considered fatal in Ganeti. > > Otherwise the patch looks good. > > LGTM to squash into the previous patch. > > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
