LGTM, thanks On Jan 16, 2014 4:49 PM, "Klaus Aehlig" <[email protected]> wrote:
> So far, our code base does not have a consistent way of spacing > records. To work towards more consistency, add a recommendation > into out style guide. We standardize on what seems most common > in the Haskell world and also is the dominant form in our code > base. > > Signed-off-by: Klaus Aehlig <[email protected]> > --- > doc/dev-codestyle.rst | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/doc/dev-codestyle.rst b/doc/dev-codestyle.rst > index b32fda1..79261d5 100644 > --- a/doc/dev-codestyle.rst > +++ b/doc/dev-codestyle.rst > @@ -351,6 +351,18 @@ following is also allowed:: > , value2 > ] > > +For records, always add spaces around the braces and the equality sign. > +:: > + > + foo = Foo { fBar = "bar", fBaz = 4711 } > + > + foo' = Foo { fBar = "bar 2" > + , fBaz = 4712 > + } > + > + node' = node { ip = "127.0.0.1" } > + > + > White space > ~~~~~~~~~~~ > Like in Python, surround binary operators with one space on either side. > Do no > -- > 1.8.5.2 > >
