LGTM, thanks.
On Thu, Jan 23, 2014 at 2:08 PM, Klaus Aehlig <[email protected]> wrote: > > Otherwise LGTM, thanks (no need to resend). > > FYI: > > Interdiff > > diff --git a/doc/dev-codestyle.rst b/doc/dev-codestyle.rst > index 56559d6..daab9ad 100644 > --- a/doc/dev-codestyle.rst > +++ b/doc/dev-codestyle.rst > @@ -484,7 +484,7 @@ control flows need to be considered and compiler > support is limited. > Therefore, Ganeti functions should never allow exceptions to escape. > Function that can fail should report failure by returning an appropriate > sum type (``Either`` or one of its glorified variants like ``Maybe`` or > -``Result``). > +``Result``); the preferred sum type for reporting errors is ``Result``. > > As other Ganeti functions also follow these guide lines, they can safely > be composed. However, be careful when using functions from other > libraries; > > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
