LGTM, thanks.
On Fri, Jan 24, 2014 at 1:23 PM, Klaus Aehlig <[email protected]> wrote: > > In Python, the call to rename perspective_job_rename returns an array of > > None of the same length as the list of files. This is converted into a > list > > of nulls in JSON and this is why we need to check it against the mapped > > call list. > > > > Is it right? > > Yes, that's right. > > > Maybe it'd be worth including a comment, as receiving a list > > of nulls is a bit unexpected. > > Good idea. > > Interdiff [PATCH stable-2.11 1/8] Fix expectation for the return value > of jobqueue_rename > > diff --git a/src/Ganeti/Rpc.hs b/src/Ganeti/Rpc.hs > index a6a95a8..5dd0da8 100644 > --- a/src/Ganeti/Rpc.hs > +++ b/src/Ganeti/Rpc.hs > @@ -622,6 +622,9 @@ instance RpcCall RpcCallJobqueueRename where > > instance Rpc RpcCallJobqueueRename RpcResultJobqueueRename where > rpcResultFill call res = > + -- Upon success, the RPC returns the list of return values of > + -- the rename operations, which is always None, serialized to > + -- null in JSON. > let expected = J.showJSON . map (const J.JSNull) > $ rpcCallJobqueueRenameRename call > in if res == expected > > > > Otherwise, LGTM, thanks. > > Thanks. > > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
