Hello team, From 2.10 to 2.11 luxid becomes responsible for generating the OpCodes for the Jobs to be submitted to masterd. This produces a major regression with regard to the ExtStorage interface and changes the way arbitrary ExtStorage parameters were handled in versions < 2.11.
The way that IDiskParams is implemented in Haskell does not follow the previous Python code and doesn't allow any arbitrary params to be passed as diskparams, which are required by the ExtStorage (and are documented in man pages). For example if we run: gnt-instance add -t ext --disk 0:size=1G,provider=shared_filer,shared_dir=/srv ... the shared_dir parameter is *not* passed to the LU as it should. Furthermore, an other problem is, that for templates other than Ext, arbitrary parameters are not being checked/verified as happened before and are now silently ignored without producing any error messages as happened with Python verification code for the OpCodes. For example if we run: gnt-instance add -t file --disk 0:size=1,foo=bar ... then there will be no error messages whatsoever. I think the above should be addressed before cutting the release-2.11 branch. Kind Regards, Ilias -- Ilias Tsitsimpis OpenPGP public key ID: pub 4096R/25F3E3EE 2012-11-02 Ilias Tsitsimpis <[email protected]> Key fingerprint = 1986 21F5 7024 9B25 F4E2 4EF7 6FB8 90BA 25F3 E3EE
signature.asc
Description: Digital signature
