LGTM, thanks
On Thu, Feb 6, 2014 at 3:29 PM, Klaus Aehlig <[email protected]> wrote: > In that way, we explicitly name the operations that are not > handled by luxid and explain the reason. In particular, we > can be sure that newly added luxid operations won't be forgotten > in luxid. > > Signed-off-by: Klaus Aehlig <[email protected]> > --- > src/Ganeti/Query/Server.hs | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/Ganeti/Query/Server.hs b/src/Ganeti/Query/Server.hs > index 49c61da..9fdc2d5 100644 > --- a/src/Ganeti/Query/Server.hs > +++ b/src/Ganeti/Query/Server.hs > @@ -387,9 +387,9 @@ handleCall qlock _ cfg (AutoArchiveJobs age timeout) = > do > $ sortJobIDs jids > return . Ok $ showJSON result > > -handleCall _ _ _ op = > - return . Bad $ > - GenericError ("Luxi call '" ++ strOfOp op ++ "' not implemented") > +handleCall _ _ _ (PickupJob _) = > + return . Bad > + $ GenericError "Luxi call 'PickupJob' is for internal use only" > > {-# ANN handleCall "HLint: ignore Too strict if" #-} > > -- > 1.9.0.rc1.175.g0b1dcb5 > >
