LGTM. Thanks, Jose
On Thu, Feb 06, 2014 at 05:24:08PM +0100, Santi Raffa wrote: > This RPC's instance_osp input has a non-obvious, non documented > type. This patch adds documentation to this RPC. > > Signed-off-by: Santi Raffa <[email protected]> > --- > lib/rpc_defs.py | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/lib/rpc_defs.py b/lib/rpc_defs.py > index 6650c43..7fbbc16 100644 > --- a/lib/rpc_defs.py > +++ b/lib/rpc_defs.py > @@ -288,10 +288,12 @@ _INSTANCE_CALLS = [ > ("reason", None, "The reason for the startup"), > ], None, None, "Starts an instance"), > ("instance_os_add", SINGLE, None, constants.RPC_TMO_1DAY, [ > - ("instance_osp", ED_INST_DICT_OSP_DP, None), > - ("reinstall", None, None), > - ("debug", None, None), > - ], None, None, "Starts an instance"), > + ("instance_osp", ED_INST_DICT_OSP_DP, "Tuple: (target instance," > + " temporary OS parameters" > + " overriding configuration)"), > + ("reinstall", None, "Whether the instance is being reinstalled"), > + ("debug", None, "Debug level for the OS install script to use"), > + ], None, None, "Installs an operative system onto an instance"), > ("hotplug_device", SINGLE, None, constants.RPC_TMO_NORMAL, [ > ("instance", ED_INST_DICT, "Instance object"), > ("action", None, "Hotplug Action"), > -- > 1.9.0.rc1.175.g0b1dcb5 > -- Jose Antonio Lopes Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
