On Mon, Feb 10, 2014 at 11:17 AM, Jose A. Lopes <[email protected]>wrote:
> This patch fixes a type discrepancy between the Haskell type > 'Ganeti.OpCodes.JobIdListOnly' and the Python type predicate > 'ganeti.ht.TJobIdListOnly', the former being a list and the latter a > dictionary. > > Signed-off-by: Jose A. Lopes <[email protected]> > --- > src/Ganeti/OpCodes.hs | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/Ganeti/OpCodes.hs b/src/Ganeti/OpCodes.hs > index 239ff70..8cf15b7 100644 > --- a/src/Ganeti/OpCodes.hs > +++ b/src/Ganeti/OpCodes.hs > @@ -78,10 +78,10 @@ instance PyValue a => PyValue (SetParamsMods a) where > > instance PyValue a => PyValue (NonNegative a) where > showValue = showValue . fromNonNegative > - > + > What is this? Adding or removing whitespace? Since it looks not directly related to your change, mention the reformatting in the patch description at least or leave out the reformatting :) > instance PyValue a => PyValue (NonEmpty a) where > showValue = showValue . fromNonEmpty > - > + > -- FIXME: should use the 'toRaw' function instead of being harcoded or > -- perhaps use something similar to the NonNegative type instead of > -- using the declareSADT > @@ -107,7 +107,7 @@ instance PyValue JSValue where > showValue (JSObject obj) = showValue obj > showValue x = show x > > -type JobIdListOnly = [(Bool, Either String JobId)] > +type JobIdListOnly = Map String [(Bool, Either String JobId)] > > type InstanceMultiAllocResponse = > ([(Bool, Either String JobId)], NonEmptyString) > -- > 1.9.0.rc1.175.g0b1dcb5 > > Otherwise, LGTM -- -- Helga Velroyen | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
