LGTM, thanks
On Wed, Feb 19, 2014 at 11:01 AM, Hrvoje Ribicic <[email protected]> wrote: > The wait that is used for gnt-job cancel could cause flakiness if the > wait is small enough for the job not to get canceled. This patch > doubles the waiting time - more than that is unfortunately probably a > bug. > > Signed-off-by: Hrvoje Ribicic <[email protected]> > --- > qa/qa_job.py | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/qa/qa_job.py b/qa/qa_job.py > index ed2bf4a..8ff2ba5 100644 > --- a/qa/qa_job.py > +++ b/qa/qa_job.py > @@ -131,7 +131,11 @@ def TestJobCancellation(): > retry_fn = functools.partial(_RetryingFetchJobStatus, > constants.JOB_STATUS_CANCELING, job_id) > try: > - job_status = retry.Retry(retry_fn, 2.0, 2 * FIRST_COMMAND_DELAY) > + # The multiplier to use is arbitrary, setting it higher could > prevent > + # flakiness > + WAIT_MULTIPLIER = 4.0 > + job_status = retry.Retry(retry_fn, 2.0, > + WAIT_MULTIPLIER * FIRST_COMMAND_DELAY) > except retry.RetryTimeout: > # The job status remains the same > pass > -- > 1.7.10.4 > > -- -- Helga Velroyen | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
