On Wed, Feb 19, 2014 at 2:56 PM, Klaus Aehlig <[email protected]> wrote:

> On Wed, Feb 19, 2014 at 02:25:54PM +0100, Helga Velroyen wrote:
> > Since 2.6, hbal crashes when used on a cluster where no
> > LVM storage is enabled at all. The problem is that it
> > always queries for fields that only sometimes make
> > sense for certain types of storage. This patch will
> > make it fall-back to a default value if those fields
> > are not returned by a query. This way it will simply
> > disregard the space information in its calculation
> > which is the best we can do in this situation, because
> > not all storage types support space reporting.
> >
> > Signed-off-by: Helga Velroyen <[email protected]>
> > ---
> >  src/Ganeti/HTools/Backend/Rapi.hs | 10 ++++++----
> >  1 file changed, 6 insertions(+), 4 deletions(-)
>
> The patch looks good, by if it is broken in so old versions,
> why not rebase to 2.9, or even 2.8, and move it to 2.10
> by means of merges. In that way, we have it ready, if and
> when we decide to make a new 2.9 relase and won't forget to
> cherry-pick it.
>

Okay, I'll rebase it to 2.8 then.

Cheers,
Helga


>
> --
> Klaus Aehlig
> Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
> Registergericht und -nummer: Hamburg, HRB 86891
> Sitz der Gesellschaft: Hamburg
> Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
>



-- 
-- 
Helga Velroyen | Software Engineer | [email protected] |

Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to