Hi!
On Thu, Feb 20, 2014 at 9:41 AM, Michele Tartara <[email protected]>wrote: > Modify the build_chroot script to support Ubuntu Precise as a target > environment. > > Signed-off-by: Michele Tartara <[email protected]> > --- > devel/build_chroot | 37 ++++++++++++++++++++++++++++++++++++- > 1 file changed, 36 insertions(+), 1 deletion(-) > > diff --git a/devel/build_chroot b/devel/build_chroot > index b622e81..5640cc7 100755 > --- a/devel/build_chroot > +++ b/devel/build_chroot > @@ -256,9 +256,44 @@ case $DIST_RELEASE in > in_chroot -- \ > cabal install --global base64-bytestring > ;; > + precise) > + echo "Adding universe repository..." > + cat > $CHDIR/etc/apt/sources.list.d/universe.list <<EOF > I think it would be good to add a comment why this is necessary (for future maintenance of this script). > +deb http://archive.ubuntu.com/ubuntu precise universe > +EOF > + in_chroot -- \ > + apt-get update > > - *) > + echo "Installing packages" > + in_chroot -- \ > + $APT_INSTALL \ > + autoconf automake ghc ghc-haddock libghc-network-dev \ > + libghc-test-framework{,-hunit,-quickcheck2}-dev \ > + libghc-json-dev libghc-curl-dev libghc-hinotify-dev \ > + libghc-parallel-dev libghc-utf8-string-dev \ > + libghc-hslogger-dev libghc-crypto-dev \ > + libghc-regex-pcre-dev libghc-attoparsec-dev \ > + libghc-vector-dev libghc-temporary-dev \ > + libghc-snap-server-dev libpcre3 libpcre3-dev hscolour hlint pandoc \ > + libghc-lifted-base-dev \ > + python-setuptools python-sphinx python-epydoc graphviz > python-pyparsing \ > + python-simplejson python-pyinotify python-pycurl python-paramiko \ > + python-bitarray python-ipaddr python-yaml qemu-utils > python-coverage pep8 \ > + python-dev pylint openssh-client vim git git-email \ > + build-essential > > + echo "Installing cabal packages" > + in_chroot -- \ > + $APT_INSTALL cabal-install > + > + in_chroot -- \ > + cabal update > + > + in_chroot -- \ > + cabal install --global shelltestrunner > + ;; > + > + *) > in_chroot -- \ > $APT_INSTALL \ > autoconf automake ghc ghc-haddock libghc-network-dev \ > -- > 1.9.0.rc1.175.g0b1dcb5 > > With or without my comment above, LGTM, thanks! -- -- Helga Velroyen | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
