LGTM, thanks.

On Tue, Feb 18, 2014 at 3:39 PM, Hrvoje Ribicic <[email protected]> wrote:

> The previously introduced changes caused some tests to fail. This patch
> alters the tests to expect different values, while still ensuring
> correct behavior.
>
> Signed-off-by: Hrvoje Ribicic <[email protected]>
> ---
>  test/py/cmdlib/test_unittest.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/test/py/cmdlib/test_unittest.py
> b/test/py/cmdlib/test_unittest.py
> index 92f9d02..47fc761 100644
> --- a/test/py/cmdlib/test_unittest.py
> +++ b/test/py/cmdlib/test_unittest.py
> @@ -47,7 +47,7 @@ class TestLUTestDelay(CmdlibTestCase):
>    def testInvalidDuration(self):
>      op = opcodes.OpTestDelay(duration=-1)
>
> -    self.ExecOpCodeExpectOpExecError(op)
> +    self.ExecOpCodeExpectOpPrereqError(op)
>
>    def testOnNodeUuid(self):
>      node_uuids = [self.master_uuid]
> @@ -93,7 +93,8 @@ class TestLUTestDelay(CmdlibTestCase):
>      node1 = self.cfg.AddNewNode()
>      node2 = self.cfg.AddNewNode()
>      op = opcodes.OpTestDelay(duration=DELAY_DURATION,
> -                             on_nodes=[node1.name, node2.name])
> +                             on_nodes=[node1.name, node2.name],
> +                             on_master=False)
>
>      self.rpc.call_test_delay.return_value = \
>        self.RpcResultsBuilder() \
> --
> 1.9.0.rc1.175.g0b1dcb5
>
>

Reply via email to