LGTM
On Feb 24 09:45, Petr Pudlak wrote: > The test checks if the first node in the list is the primary node, but > because it names the node so that it's the least one alphabetically, the > test always succeeds. This fixes the test. > > Signed-off-by: Petr Pudlak <[email protected]> > --- > test/py/ganeti.objects_unittest.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/test/py/ganeti.objects_unittest.py > b/test/py/ganeti.objects_unittest.py > index 919a1e8..72163db 100755 > --- a/test/py/ganeti.objects_unittest.py > +++ b/test/py/ganeti.objects_unittest.py > @@ -356,10 +356,10 @@ class TestInstance(unittest.TestCase): > > def testNodesDrbdDisks(self): > inst = objects.Instance(name="fakeinstdrbd.example.com", > - primary_node="node10.example.com", > + primary_node="node20.example.com", > disks=[ > objects.Disk(dev_type=constants.DT_DRBD8, size=786432, > - logical_id=("node10.example.com", "node15.example.com", > + logical_id=("node20.example.com", "node15.example.com", > 12300, 0, 0, "secret"), > children=[ > objects.Disk(dev_type=constants.DT_PLAIN, size=786432, > -- > 1.9.0.rc1.175.g0b1dcb5 > -- Jose Antonio Lopes Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
