Can you please add another test that fails with the empty string. Rest LGTM.
Thanks, Jose On Feb 27 17:38, Dimitris Bliablias wrote: > Add unittest for cluster mac-prefix modification support. > --- > test/py/cmdlib/cluster_unittest.py | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/test/py/cmdlib/cluster_unittest.py > b/test/py/cmdlib/cluster_unittest.py > index 6fce290..13c768e 100644 > --- a/test/py/cmdlib/cluster_unittest.py > +++ b/test/py/cmdlib/cluster_unittest.py > @@ -403,6 +403,12 @@ class TestLUClusterSetParams(CmdlibTestCase): > self.ExecOpCode(op) > self.assertEqual(additional_pool, self.cluster.uid_pool) > > + def testMacPrefix(self): > + mac_prefix = "aa:01:02" > + op = opcodes.OpClusterSetParams(mac_prefix=mac_prefix) > + self.ExecOpCode(op) > + self.assertEqual(mac_prefix, self.cluster.mac_prefix) > + > def testMasterNetmask(self): > op = opcodes.OpClusterSetParams(master_netmask=26) > self.ExecOpCode(op) > -- > 1.7.10.4 > -- Jose Antonio Lopes Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
