LGTM, thanks.

On Mon, Mar 3, 2014 at 4:51 PM, Klaus Aehlig <[email protected]> wrote:

> On Mon, Mar 03, 2014 at 04:20:44PM +0100, Petr Pudlák wrote:
> > On Mon, Mar 3, 2014 at 2:48 PM, Klaus Aehlig <[email protected]> wrote:
> >
> > > Export the functionality to export all locks to a given set.
> > >
> >
> > The second  'export' is probably a typo, should be "restrict", "limit" or
> > something like that.
>
> Reworded as follows.
>
> commit ba5cf3e93d3698968595baa2349d139702caed91
> Author: Klaus Aehlig <[email protected]>
> Date:   Mon Mar 3 13:53:31 2014 +0100
>
>     Export lock intersection through WConfD
>
>     Export the functionality to restrict the owned locks to a given set.
>
> diff --git a/src/Ganeti/WConfd/Core.hs b/src/Ganeti/WConfd/Core.hs
> index 759d6c1..b8e4e72 100644
> --- a/src/Ganeti/WConfd/Core.hs
> +++ b/src/Ganeti/WConfd/Core.hs
> @@ -76,6 +76,11 @@ freeLocks :: JobId -> FilePath -> WConfdMonad ()
>  freeLocks jid fpath =
>    modifyLockAllocation_ (`L.freeLocks` (jid, fpath))
>
> +-- | Intersect the possesed locks of an owner with a given set.
> +intersectLocks :: JobId -> FilePath -> [GanetiLocks] -> WConfdMonad ()
> +intersectLocks jid fpath =
> + modifyLockAllocation_ . L.intersectLocks (jid,fpath)
> +
>  -- * The list of all functions exported to RPC.
>
>  exportedFunctions :: [Name]
> @@ -85,4 +90,5 @@ exportedFunctions = [ 'echo
>                      , 'listLocks
>                      , 'tryUpdateLocks
>                      , 'freeLocks
> +                    , 'intersectLocks
>                      ]
>
>
> --
> Klaus Aehlig
> Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
> Registergericht und -nummer: Hamburg, HRB 86891
> Sitz der Gesellschaft: Hamburg
> Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
>

Reply via email to