Thanks.
On Mon, Mar 3, 2014 at 4:55 PM, Klaus Aehlig <[email protected]> wrote: > > It seems that TH uses types somewhat ambiguously (at least between > > versions) and the patch series fails to compile in my squeeze schroot, > > because 'varName' doesn't match on a tuple. > > > > Adding this case to 'varName' fixes the problem: > > > > varName idx (AppT (AppT (TupleT 2) t) t') > > = pairOf idx t t' > > > > (I observed the issue in the past, this is why all the cases have two > > variants.) > > > FYI > > commit 0fec495ef154e68924a8ea06c9eb1c2fe0dc9223 > Author: Klaus Aehlig <[email protected]> > Date: Mon Mar 3 16:53:40 2014 +0100 > > Interdiff [PATCH master 09/10] Support name generation for pairs > > diff --git a/src/Ganeti/THH/PyRPC.hs b/src/Ganeti/THH/PyRPC.hs > index a607c53..729075c 100644 > --- a/src/Ganeti/THH/PyRPC.hs > +++ b/src/Ganeti/THH/PyRPC.hs > @@ -98,6 +98,8 @@ toFunc fname as = do > varName idx (AppT ListT t) = listOf idx t > varName idx (AppT (ConT n) t) > | n == ''[] = listOf idx t > + varName idx (AppT (AppT (TupleT 2) t) t') > + = pairOf idx t t' > varName idx (AppT (AppT (ConT n) t) t') > | n == ''(,) = pairOf idx t t' > varName idx t = do > > > > Otherwise LGTM, no need to resend. > > Thanks. > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
