Thanks for noticing, this is a typo. Interdiff:

diff --git a/devel/build_chroot b/devel/build_chroot
index 0d69057..37a367f 100755
--- a/devel/build_chroot
+++ b/devel/build_chroot
@@ -151,7 +151,7 @@ export -f verify_sha1

 # arguments: URL
 function lookup_sha1 {
-  grep -o "${URL##*/}"'\s\+[0-9a-fA-F]*' <<<"$SHA1_LIST" | awk '{print
$2;exit}'
+  grep -o "${1##*/}"'\s\+[0-9a-fA-F]*' <<<"$SHA1_LIST" | awk '{print
$2;exit}'
 }
 export -f lookup_sha1




On Thu, Mar 6, 2014 at 3:57 PM, Klaus Aehlig <[email protected]> wrote:

> On Thu, Mar 06, 2014 at 03:44:58PM +0100, Petr Pudlak wrote:
> > Since the default GHC6 isn't usable for modern libraries and starting
> > from wheezy there is GHC7 anyway, download and install the current
> > vanilla version as well as the latest Cabal.
> >
> > Use the current up-to-date libraries.
> >
> > Also enhance the check for test-framework so that it works for the
> > recent version.
> >
> > Signed-off-by: Petr Pudlak <[email protected]>
> > ---
> >  configure.ac       |   6 +-
> >  devel/build_chroot | 174
> +++++++++++++++++++++++++++++++++++++++--------------
> >  2 files changed, 135 insertions(+), 45 deletions(-)
>
> > +# arguments: URL
> > +function lookup_sha1 {
> > +  grep -o "${URL##*/}"'\s\+[0-9a-fA-F]*' <<<"$SHA1_LIST" | awk '{print
> $2;exit}'
> > +}
> > +export -f lookup_sha1
> > +
> > +# arguments : file_name URL
> > +function download {
> > +  local FNAME="$1"
> > +  local URL="$2"
> > +  wget --output-document="$FNAME" "$URL"
> > +  verify_sha1 "$FNAME" "$( lookup_sha1 "$URL" )"
>
> If the argument to lookup_sha1 is passed as a named parameter,
> why the positional argument? (Note that lookup_sha1 completely
> ignores $1)
>
>
> The rest looks good.
>
> --
> Klaus Aehlig
> Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
> Registergericht und -nummer: Hamburg, HRB 86891
> Sitz der Gesellschaft: Hamburg
> Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
>

Reply via email to