Hi!

On Mon, Mar 17, 2014 at 1:46 PM, Petr Pudlak <[email protected]> wrote:

> .. to comply with the updated WConfd interface.
>
> This makes the call less useful as the thread ID is often unknown to
> users. This needs to be improved in the future.
>

I agree with that. Please open an issue for this so that we can keep track
of it.


>
> Signed-off-by: Petr Pudlak <[email protected]>
> ---
>  lib/client/gnt_debug.py | 10 +++++-----
>  man/gnt-debug.rst       |  6 +++---
>  2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/lib/client/gnt_debug.py b/lib/client/gnt_debug.py
> index 67f6092..6258d8e 100644
> --- a/lib/client/gnt_debug.py
> +++ b/lib/client/gnt_debug.py
> @@ -639,12 +639,12 @@ def Wconfd(opts, args): # pylint: disable=W0613
>      result = wconfd.Client().Echo(args[1])
>      print "Answer: %s" % (result,)
>    elif args[0] == "listlocks":
> -    if len(args) != 2:
> -      ToStderr("Command 'listlocks' takes only precisely argument.")
> +    if len(args) != 3:
> +      ToStderr("Command 'listlocks' takes precisely two arguments.")
>        return 1
> -    result = \
> -        wconfd.Client().ListLocks(int(args[1]),
> -
>  utils.livelock.GuessLockfileFor("masterd"))
> +    wconfdcontext = (int(args[1]), int(args[2]),
> +                     utils.livelock.GuessLockfileFor("masterd"))
> +    result = wconfd.Client().ListLocks(wconfdcontext)
>      print "Answer: %s" % (result,)
>    else:
>      ToStderr("Command '%s' not supported", args[0])
> diff --git a/man/gnt-debug.rst b/man/gnt-debug.rst
> index 32eec4e..b923f13 100644
> --- a/man/gnt-debug.rst
> +++ b/man/gnt-debug.rst
> @@ -138,10 +138,10 @@ Tests the WConf daemon by invoking its ``echo``
> function.
>  A given text is sent to WConfd through RPC, echoed back by WConfd and
>  printed to the console.
>
> -| **wconfd** listlocks *jid*
> +| **wconfd** listlocks *jid* *threadid*
>
> -A request to list the locks owned by the given job id is sent to WConfd
> -and the answer is displayed.
> +A request to list the locks owned by the given job id and thread id is
> +sent to WConfd and the answer is displayed.
>
>  .. vim: set textwidth=72 :
>  .. Local Variables:
> --
> 1.9.0.279.gdc9e3eb
>
>
LGTM, thanks!

Helga

-- 
-- 
Helga Velroyen | Software Engineer | [email protected] |

Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to