LGTM, thanks.
On Wed, Mar 26, 2014 at 2:25 PM, Hrvoje Ribicic <[email protected]> wrote: > This patch adds the RAPI symmetry test for nodes. > > Signed-off-by: Hrvoje Ribicic <[email protected]> > --- > qa/qa_rapi.py | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/qa/qa_rapi.py b/qa/qa_rapi.py > index b3b3d2f..383d5e6 100644 > --- a/qa/qa_rapi.py > +++ b/qa/qa_rapi.py > @@ -520,6 +520,20 @@ def TestNode(node): > ("/2/nodes?bulk=1", _VerifyNodesBulk, "GET", None), > ]) > > + # Not parameters of the node, but controlling opcode behavior > + LEGITIMATELY_MISSING = ["force", "powered"] > + # Identifying the node - RAPI provides these itself > + IDENTIFIERS = ["node_name", "node_uuid"] > + # As the name states, these can be set but not retrieved yet > + NOT_EXPOSED_YET = ["hv_state", "disk_state", "auto_promote"] > + > + _DoGetPutTests("/2/nodes/%s" % node.primary, > + "/2/nodes/%s/modify" % node.primary, > + opcodes.OpNodeSetParams.OP_PARAMS, > + modify_method="POST", > + exceptions=(LEGITIMATELY_MISSING + NOT_EXPOSED_YET + > + IDENTIFIERS)) > + > > def _FilterTags(seq): > """Removes unwanted tags from a sequence. > -- > 1.9.1.423.g4596e3a > > -- Thomas Thrainer | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
