Thanks for catching that, fixed.
On Mon, Mar 31, 2014 at 1:11 PM, Klaus Aehlig <[email protected]> wrote: > On Mon, Mar 31, 2014 at 12:49:05PM +0200, Petr Pudlak wrote: > > The ConfigWriter now allows nested locking calls, and acquires > > (releases) the config lock from WConfd only the first (last) time. > > > > This is needed for blocks that acquire a lock on the configuration and > > use synchronized configuration calls inside. While this should be > > avoided in general, it is required for some special circumstances. > > > > Also add a warning that ConfigWriter isn't thread-safe any more. > > > > Signed-off-by: Petr Pudlak <[email protected]> > > --- > > > diff --git a/lib/config.py b/lib/config.py > > index f95a4e7..8242a2c 100644 > > --- a/lib/config.py > > +++ b/lib/config.py > > @@ -257,6 +257,9 @@ class ConfigManager(object): > > class ConfigWriter(object): > > """The interface to the cluster configuration. > > > > + WARNING: The class is no longer thread-safe! > > + Each thread must to construct a separate instance. > > s/to// ? > > > + > > @ivar _temporary_lvs: reservation manager for temporary LVs > > @ivar _all_rms: a list of all temporary reservation managers > > > > LGTM > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
