LGTM, thanks
On Tue, Apr 1, 2014 at 11:17 AM, Helga Velroyen <[email protected]> wrote: > Interdiff for riba's suggestions: > > diff --git a/lib/client/gnt_instance.py b/lib/client/gnt_instance.py > index 6acaa81..3f26fcf 100644 > --- a/lib/client/gnt_instance.py > +++ b/lib/client/gnt_instance.py > @@ -1318,7 +1318,7 @@ def SetInstanceParams(opts, args): > for action, _, __ in nics: > if action == constants.DDM_MODIFY and opts.hotplug and not opts.force: > usertext = ("You are about to hot-modify a NIC. This will be done" > - " by removing the existing and then adding a new one." > + " by removing the existing NIC and then adding a new > one." > " Network connection might be lost. Continue?") > if not AskUser(usertext): > return 1 > diff --git a/lib/storage/filestorage.py b/lib/storage/filestorage.py > index 1fe01e5..418b320 100644 > --- a/lib/storage/filestorage.py > +++ b/lib/storage/filestorage.py > @@ -188,7 +188,7 @@ def _CheckFileStoragePathExistance(path): > > """ > if not os.path.isdir(path): > - raise errors.FileStoragePathError("Path '%s' is not existing or not a" > + raise errors.FileStoragePathError("Path '%s' does not exist or is not > a" > " directory." % path) > if not os.access(path, os.W_OK): > raise errors.FileStoragePathError("Path '%s' is not writable" % path) > > > Will fix the patch description according to aehlig's remark as well. > > Cheers, > Helga > > > > On Tue, Apr 1, 2014 at 11:11 AM, Klaus Aehlig <[email protected]> wrote: > >> On Tue, Apr 01, 2014 at 11:02:29AM +0200, Helga Velroyen wrote: >> > This patch fixes two typos of the work 'exisiting'. >> >> s/work/word >> >> > >> > Signed-off-by: Helga Velroyen <[email protected]> >> > --- >> > lib/client/gnt_instance.py | 2 +- >> > lib/storage/filestorage.py | 2 +- >> > 2 files changed, 2 insertions(+), 2 deletions(-) >> >> Rest LGTM >> >> -- >> Klaus Aehlig >> Google Germany GmbH, Dienerstr. 12, 80331 Muenchen >> Registergericht und -nummer: Hamburg, HRB 86891 >> Sitz der Gesellschaft: Hamburg >> Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >> > > > > -- > -- > Helga Velroyen | Software Engineer | [email protected] | > > Google Germany GmbH > Dienerstr. 12 > 80331 München > > > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Christine Elizabeth Flores >
