LGTM, thanks
On Thu, Apr 10, 2014 at 6:29 PM, Jose A. Lopes <[email protected]> wrote: > For some strange reason, Xen once printed 'rb----' which does not make > any sense because an instance cannot be both running and blocked. > Fortunately, for Ganeti 'running' or 'blocked' is the same as > 'running'. > > Signed-off-by: Jose A. Lopes <[email protected]> > --- > lib/hypervisor/hv_xen.py | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/hypervisor/hv_xen.py b/lib/hypervisor/hv_xen.py > index 8eec20c..b1fc96c 100644 > --- a/lib/hypervisor/hv_xen.py > +++ b/lib/hypervisor/hv_xen.py > @@ -173,9 +173,15 @@ def _GetAllInstanceList(fn, include_node, _timeout=5): > # > # An instance is running if it is in the following Xen states: > # running, blocked, or paused. > +# > +# For some strange reason, Xen once printed 'rb----' which does not > +# make any sense because an instance cannot be both running and > +# blocked. Fortunately, for Ganeti 'running' or 'blocked' is the same > +# as 'running'. > def _IsInstanceRunning(instance_info): > return instance_info == "r-----" \ > or instance_info == "-b----" \ > + or instance_info == "rb----" \ > or instance_info == "--p---" > > > -- > 1.9.1.423.g4596e3a > >
